fix(std/path) duplicate export sep/SEP and naming conventions #3332
Conversation
|
|
|
I just noticed there are a lot of formatting changes that aren't intentional and I am working on removing them from this PR. |
kalisjoshua
force-pushed
the
path-issue-3194
branch
5 times, most recently
from
d093a70 to
f6efa0c
Compare
|
Just checking in on this to see if there is anything I can add/remove/change to keep this moving forward? |
path/_separator.ts
Outdated
| export const sepPattern = isWindows ? /[\\/]+/ : /\/+/; | ||
| // @deprecated (will be removed after 0.187.0) use `sepPattern` | ||
| export const SEP_PATTERN = sepPattern; |
There was a problem hiding this comment.
The outcome of the discussions was to keep using upper snake case for constants: denoland/manual#625
There was a problem hiding this comment.
@nayeemrmn good to know thank you. I will take a look and see if anything is necessary for this PR to continue or not. I will close it if I don't think anything is needed to change.
kalisjoshua
force-pushed
the
path-issue-3194
branch
from
eb46803 to
5e2f307
Compare
|
Reviewing the changes I made the only thing that remains as a possible change and likely very low priority is bullet 4 (above) changing the filename of |
|
Keeping
I think this change is not desired. We usually prefer to allow importing items from its own file (to allow optimizing the dependency graph). (See #2936 for reference). We use |
|
Closing because there is nothing more to change for this issue or branch. |
issue: #3194
Summary
@deprecatedtags to each variable that will be removed in a future versionseparators.tsfile to_separators.tsto align with the naming convention for files that should not be linked to directly_separators.tsto detail why the file is necessaryI am completely open to suggestion/debate on anything proposed herein.